add more bee lines #161
Open
add more bee lines #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Shouldn't Deep Frozen Ocean be ICY?
There was a problem hiding this comment.
The surface isnt frozen so it doesnt seem that icy. Plus the actual deep part is always at 4C due to density
src/main/java/forestry/apiculture/hives/HiveGenCaveCeiling.java
Outdated
Show resolved
Hide resolved
| @@ -361,6 +356,10 @@ private void tickBreed() { | |||
| // Mate and replace princess with queen | |||
| IBee princess = (IBee) IIndividualHandlerItem.getIndividual(princessStack); | |||
| IBee drone = (IBee) IIndividualHandlerItem.getIndividual(droneStack); | |||
| // If nether princess is outside nether it zombifies. Drones can breed in the short life they have so species may persist in secondary trait | |||
| if(princess.getSpecies().getGenusName().equals(ForestryTaxa.GENUS_EMBITTERED) && housing.getWorldObj().dimension()!=Level.NETHER){ | |||
There was a problem hiding this comment.
This should be an event. I can implement this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following lines were added: Lush, Solar, Relic, Aquatic, Embittered in addition to Shulking(End line) and Custodian(sculk).
Stuff still needing to be done:
-All new hives need textures. Ideally aquatics should be restricted to coral reefs. Lush could do with the cave vine hanging from it being fully grown at world gen.
-Chest and sniffer generation of bees. I dont think loot is working at all.
-Some bees need new items for drops: xp drop and shulker shard
-Sculk effect could use sculk vein growth
-Relic line needs its special effects implemented: Rejuventation should cause the lifespan of bees excluding itself to go up by a % such that at normal lifespan it matches the rate at which they age. This should only apply once per bee life tick so its application should be kept track of in the apiary. Chronophage does the opposite, a bee with normal life ages twice as fast.
-Other needed bee processing logic tweaks:
+if a bee has the flyer trait it should still see the sky with water above it so long as some light still reaches it(i think i saw a function for that in level)
+hive should still count as seeing the sky if sky light level is 14 instead of 15 so a single leaf layer doesnt stop it
+hive should check if its raining in general unless it is in a cave, so as to not allow nullifying rain by placing a transparent block on the hive
i cannot find where the logic is being run so i cant change them myself
-Bee descriptions attributed to Prof.Griansworth should be made more posh