Add support for phpstan 1.0 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@thecodingmachine There didn't seem to be any BC breaks needing addressing with this change. Can you add this and tag please? |
|
@alexander-schranz @mbadolato I added an alias from "1.0" to the "master" branch and I'll merge this right now. Thanks a lot @alexander-schranz for the PR. Before I tag the 1.0.0, could you let me know if this works as expected on your projects? |
|
@moufmouf Thx for merging. Did work for me so nothing against it from my side to tag it. |
|
@moufmouf Thank you for the release! |
|
You are welcome 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will set the required phpstan version to 1.0. Would I think be also a good time to tag also this package with 1.0 thats why I did not add it as additional allowed version.