Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Remove Safe #22

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Remove Safe #22

merged 2 commits into from
Dec 30, 2020

Conversation

rodnaph
Copy link
Contributor

@rodnaph rodnaph commented Dec 28, 2020

Summary

Removes thecodingmachine/safe from the dependencies as suggested for PHP 7.1 support.

Test plan (required)

The existing test suite should remain green.

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • Have you lint your code locally prior to submission (make lint)?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally (make tests)?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@rodnaph
Copy link
Contributor Author

rodnaph commented Dec 28, 2020

@gulien What's the deal with the codecov/travis-ci build steps, should they be running? Looks like the travis one passed on the last PR merged, but something has happened with a migration to travis-ci.com (I'm not familiar with this tool sorry).

https://travis-ci.com/github/thecodingmachine/gotenberg-php-client

@gulien
Copy link
Contributor

gulien commented Dec 28, 2020

That's because Travis uses a "credit" system, even for OSS, and thecodingmachine organization does not have credits anymore.

I guess I'll need to migrate to GitHub actions 😄

@rodnaph
Copy link
Contributor Author

rodnaph commented Dec 28, 2020

I guess I'll need to migrate to GitHub actions 😄

I'll raise another PR... 🤣

@rodnaph rodnaph force-pushed the remove-safe branch 3 times, most recently from e8146a1 to db0a8bd Compare December 28, 2020 17:16
@rodnaph
Copy link
Contributor Author

rodnaph commented Dec 28, 2020

@gulien I've moved the build to Github Actions, but it's not running on this PR as I believe you need to specifically enable it to run on forks in the repo settings. You can see the builds run on my repo though:

https://github.com/rodnaph/gotenberg-php-client/actions/runs/449204547

There are a bunch of failed builds in there too so you can see the build fails when steps fail. A tweak was needed to resolve alternative DNS for the Gotenberg service in the ClientTest.

@rodnaph
Copy link
Contributor Author

rodnaph commented Dec 29, 2020

@gulien Your suggested Github Actions changes are on this branch now.

eg. https://github.com/rodnaph/gotenberg-php-client/runs/1621077191?check_suite_focus=true

src/Client.php Outdated Show resolved Hide resolved
Copy link
Contributor

@gulien gulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gulien
Copy link
Contributor

gulien commented Dec 30, 2020

Thank your very much @rodnaph 😉

@gulien gulien merged commit 97cb313 into thecodingmachine:master Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants