-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
@gulien What's the deal with the codecov/travis-ci build steps, should they be running? Looks like the travis one passed on the last PR merged, but something has happened with a migration to travis-ci.com (I'm not familiar with this tool sorry). https://travis-ci.com/github/thecodingmachine/gotenberg-php-client |
That's because Travis uses a "credit" system, even for OSS, and thecodingmachine organization does not have credits anymore. I guess I'll need to migrate to GitHub actions 😄 |
I'll raise another PR... 🤣 |
e8146a1
to
db0a8bd
Compare
@gulien I've moved the build to Github Actions, but it's not running on this PR as I believe you need to specifically enable it to run on forks in the repo settings. You can see the builds run on my repo though: https://github.com/rodnaph/gotenberg-php-client/actions/runs/449204547 There are a bunch of failed builds in there too so you can see the build fails when steps fail. A tweak was needed to resolve alternative DNS for the Gotenberg service in the |
@gulien Your suggested Github Actions changes are on this branch now. eg. https://github.com/rodnaph/gotenberg-php-client/runs/1621077191?check_suite_focus=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank your very much @rodnaph 😉 |
Summary
Removes
thecodingmachine/safe
from the dependencies as suggested for PHP 7.1 support.Test plan (required)
The existing test suite should remain green.
Checklist
make lint
)?make tests
)?