Fix for Linux int driver omitting encryption #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
- Coverage 30.61% 30.55% -0.06%
==========================================
Files 29 29
Lines 1777 1777
==========================================
- Hits 544 543 -1
- Misses 1175 1176 +1
Partials 58 58
Continue to review full report at Codecov.
|
codenrhoden
reviewed
Mar 21, 2017
drivers/integration/linux/linux.go
Outdated
| @@ -459,8 +459,10 @@ func (d *driver) Create( | |||
| volumeType := d.volumeType() | |||
| optsNew.Type = &volumeType | |||
| io, _ := strconv.Atoi(d.iops()) | |||
There was a problem hiding this comment.
I know it's not part of this PR, but I hate seeing this err suppressed. It doesn't appear that the syntax for this config value has been validated previously, so it's possible this conversion should fail. Something worth addressing?
There was a problem hiding this comment.
Hi @codenrhoden,
I addressed this concern in a rebase. Care to review?
This patch updates the Linux integration driver so that it processes volume creation requests with encryption properly.
akutz
force-pushed
the
bugfix/linux-int-driver-enc
branch
from
d78826f to
0f4d810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the Linux integration driver so that it processes volume creation requests with encryption properly.