Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashes in RBD names and pools #425

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

codenrhoden
Copy link
Contributor

@codenrhoden codenrhoden commented Feb 21, 2017

Document allowed characters, and return a better error message when
invalid characters are found

@codenrhoden codenrhoden added this to the 0.5.0 milestone Feb 21, 2017
@codecov-io
Copy link

codecov-io commented Feb 21, 2017

Codecov Report

❗ No coverage uploaded for pull request base (release/0.5.0@9e1850f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/0.5.0     #425   +/-   ##
================================================
  Coverage                 ?   31.05%           
================================================
  Files                    ?       29           
  Lines                    ?     1752           
  Branches                 ?        0           
================================================
  Hits                     ?      544           
  Misses                   ?     1150           
  Partials                 ?       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e1850f...7202970. Read the comment docs.

@akutz
Copy link
Collaborator

akutz commented Feb 21, 2017

Please rebase this onto release/0.5.0 and/or remove the Ceph MonIP commit from this PR as it's been merged.

Document allowed characters, and return a better error message when
invalid characters are found
@akutz akutz merged commit 22adef7 into thecodeteam:release/0.5.0 Feb 21, 2017
@akutz akutz removed the in progress label Feb 21, 2017
@codenrhoden codenrhoden deleted the bugfix/rbd_naming branch April 11, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants