ScaleIO Executor Enhancements #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/0.5.0 #414 +/- ##
==============================================
Coverage 30.49% 30.49%
==============================================
Files 29 29
Lines 1741 1741
==============================================
Hits 531 531
Misses 1152 1152
Partials 58 58Continue to review full report at Codecov.
|
This patch enhances the ScaleIO executor so that the `drv_cfg` binary is no longer hard-coded and can now be configured with the configuration property `scaleio.drvCfg` which translates into the environment variable `SCALEIO_DRVCFG`. If the property `scaleio.guid` (env var `SCALEIO_GUID`) is set then the `drv_cfg` binary is not used at all to discover the client's GUID. This patch also updates the logic to discover local devices so the `drv_cfg` is no longer necessary or required to provide this information.
akutz
force-pushed
the
feature/sio-executor
branch
from
780810a to
750fde5
Compare
|
👍 This looks a lot cleaner, too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enhances the ScaleIO executor so that the
drv_cfgbinary is no longer hard-coded and can now be configured with the configuration propertyscaleio.drvCfgwhich translates into the environment variableSCALEIO_DRVCFG.If the property
scaleio.guid(env varSCALEIO_GUID) is set then thedrv_cfgbinary is not used at all to discover the client's GUID.This patch also updates the logic to discover local devices so the
drv_cfgis no longer necessary or required to provide this information.