Fix for Ceph MonIPs with Ports

[akutz]

This patch is a first-attempt at fixing a bug where the RBD executor does not properly parse CephMon addresses with ports.

This patch does not account for IPv6 addresses as those require brackets for parsing, but this should hopefully help a community user move forward sooner than later.

[codecov-io]

Codecov Report

Merging #412 into release/0.5.0 will not change coverage.

@@              Coverage Diff               @@
##           release/0.5.0     #412   +/-   ##
==============================================
  Coverage          30.44%   30.44%           
==============================================
  Files                 29       29           
  Lines               1741     1741           
==============================================
  Hits                 530      530           
  Misses              1153     1153           
  Partials              58       58

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5dbe0...1040f4c. Read the comment docs.

[codenrhoden]

I personally don't see the need to do more than this. I know you are worried about brackets with IPv6, but if it's an improperly formatted IPv6 address, I don't think we should try to fix it.

I double-checked that LookupIP will just return the IP if it's passed an IP and it does (which I'm sure you knew).

I'd say run with this, and no need to do more at this time.

[akutz]

Hi @codenrhoden,

IPv6 addresses do not require brackets except for some situations. If the CephMon IP list requires IPv6 addresses to use brackets, then we're square. If it doesn't, or worse, doesn't support brackets, then we'd need to handle that, right?

[akutz]

Hi @codenrhoden,

I'm merging this for now, and if we want to augment later, then great.

[akutz]

Closes #411.