Fix num arg checking for lsx wait #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check to make sure the lsx wait command had the minimum number of args was one less than it needs to be.
Current coverage is 30.53% (diff: 100%)@@ master #401 diff @@
==========================================
Files 29 29
Lines 1739 1739
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 530 531 +1
+ Misses 1151 1150 -1
Partials 58 58
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check to make sure the lsx wait command had the minimum number of
args was one less than it needs to be.
If you accidentally leave off the timeout param, you get panic, index out of range error from line 199: