Volume Attachment States #319
Conversation
This patch adds the AttachmentState field to the Volume object model to more summarily reflect a volume's attachment state.
akutz
force-pushed
the
feature/volume-attachment-states
branch
from
35b21f8 to
34ffe54
Compare
Current coverage is 25.01% (diff: 100%)
@@ release/0.3.3 #319 diff @@
===============================================
Files 47 47
Lines 2830 2830
Methods 0 0
Messages 0 0
Branches 0 0
===============================================
Hits 708 708
Misses 2052 2052
Partials 70 70
|
| if v.AttachmentState == 0 { | ||
| v.AttachmentState = types.VolumeAttached | ||
| } | ||
|
|
There was a problem hiding this comment.
why is this one 0 -> attached and all the others 0 -> available? My guess is that this is basically setting the default value, and if a call to Attach() is returning without an error, it can be assumed that the volume is attached. makes sense, but want to double check.
There was a problem hiding this comment.
You inferred the reasoning correctly.
There was a problem hiding this comment.
Although now that you point this out, I need to update the above to the following logic:
if v.AttachmentState == 0 && len(v.Attachments) > 0 {
if "attached to the same instance as the instance ID in the context" {
v.AttachmentState = types.VolumeAttached
} else {
v.AttachmentState = types.VolumeUnavailable
}
}
There was a problem hiding this comment.
Wait, no I won't. The API call asserts the instance ID must be included to do the attach op, which means when the volume returns the volume WILL be attached (if successful) to whichever instance was specified in the call.
| @@ -139,28 +169,28 @@ type Volume struct { | |||
| IOPS int64 `json:"iops,omitempty" yaml:"iops,omitempty"` | |||
|
|
|||
| // The name of the volume. | |||
| Name string `json:"name"` | |||
| Name string `json:"name" yaml:"name,omitempty"` | |||
There was a problem hiding this comment.
Why is YAML omitempty, but not JSON? Seems like the only outlier?
There was a problem hiding this comment.
Oh, because I got Copy/Paste happy with the YAML update. Doesn't matter ultimately because the YAML tags were originally there to influence the CLI output which is no longer based on YAML.
This patch adds the AttachmentState field to the Volume object model to more summarily reflect a volume's attachment state.