Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/feed specific topics #390

Closed
wants to merge 5 commits into from
Closed

Feat/feed specific topics #390

wants to merge 5 commits into from

Conversation

hailelagi
Copy link
Contributor

@hailelagi hailelagi commented Sep 29, 2021

addresses: #384

@jerodsanto jerodsanto marked this pull request as ready for review October 11, 2021 15:55
@jerodsanto
Copy link
Member

I think the existing FeedController is a better place for this functionality, since there is nothing new/unique about a topic feed. It's just another feed with different/specific content.

@hailelagi
Copy link
Contributor Author

Yeah, I agree that makes more sense. My initial thinking was to decouple the functionality so the controller could be smaller and avoid namespace issues but taking another look now this leads to a lot more unnecessary boilerplate.

@hailelagi
Copy link
Contributor Author

Hi @jerodsanto I kind of dropped off on this last year sorry about that, but I really want to pick it back, although it's been quite awhile! If this is something useful I'll try to dive back in! cheers

@jerodsanto
Copy link
Member

Yeah man, let's pick it back up!

@gerhard
Copy link
Member

gerhard commented Aug 23, 2022

There are a few failing tests: https://app.circleci.com/pipelines/github/thechangelog/changelog.com/812/workflows/db6d709a-3d33-49e4-9e22-b027d7fe1712/jobs/5532?invite=true#step-105-1171

When they get fixed, what needs to happen before this can get merged @jerodsanto?

@hailelagi
Copy link
Contributor Author

hailelagi commented Aug 24, 2022

I have a few changes on my local host, I think I can close this out this weekend, but happy to take any pointers on direction

@Nezteb
Copy link
Contributor

Nezteb commented Oct 2, 2022

Alright @hailelagi @gerhard I've got a PR ready for reviews: #430 (I branched off of this PR branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants