-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/feed specific topics #390
Feat/feed specific topics #390
Conversation
I think the existing |
Yeah, I agree that makes more sense. My initial thinking was to decouple the functionality so the controller could be smaller and avoid namespace issues but taking another look now this leads to a lot more unnecessary boilerplate. |
Hi @jerodsanto I kind of dropped off on this last year sorry about that, but I really want to pick it back, although it's been quite awhile! If this is something useful I'll try to dive back in! cheers |
Yeah man, let's pick it back up! |
There are a few failing tests: https://app.circleci.com/pipelines/github/thechangelog/changelog.com/812/workflows/db6d709a-3d33-49e4-9e22-b027d7fe1712/jobs/5532?invite=true#step-105-1171 When they get fixed, what needs to happen before this can get merged @jerodsanto? |
I have a few changes on my local host, I think I can close this out this weekend, but happy to take any pointers on direction |
Alright @hailelagi @gerhard I've got a PR ready for reviews: #430 (I branched off of this PR branch) |
addresses: #384