Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 support #46

Merged
merged 1 commit into from
Dec 9, 2020
Merged

PHP8 support #46

merged 1 commit into from
Dec 9, 2020

Conversation

Matth--
Copy link
Collaborator

@Matth-- Matth-- commented Dec 7, 2020 •
edited
Loading

  • Added PHP 8 as supported version
  • Twig was locked to version 3.0.0
  • Changed travis configuration so multiple versions of Symfony get tested against multiple PHP versions
  • Composer cache fixed in travis
  • Fixed ObjectManager not found warning

@Matth-- Matth-- changed the title Fix doctrine deprecations [WIP] PHP8 support Dec 7, 2020
@Matth-- Matth-- force-pushed the fix/dependencies branch 2 times, most recently from c2cfb3c to 7d32a74 Compare December 8, 2020 08:36
@Matth--
Copy link
Collaborator Author

Matth-- commented Dec 8, 2020

@Bukashk0zzz @thecatontheflat

Quick question

I added PHP 8 as a possible PHP version (works out of the box! 👍 ) but PHPUnit version 8 is not capable of generating code coverage reports on PHP 8. Do you want me to upgrade the PHPUnit version as well? The only problem there is that PHPUnit 9 supports PHP 7.3 and up.

This could be considered a BC break so I don't know if this PR should already fix that.

@Bukashk0zzz
Copy link
Collaborator

In my opinion in any case better make separate PR for PHPUnit update.

I can merge this PR as is.

@Bukashk0zzz
Copy link
Collaborator

And thank you for great job!

@Matth-- Matth-- changed the title [WIP] PHP8 support PHP8 support Dec 9, 2020
@Matth--
Add PHP 8 support
3a89f7e 
Also fixed the following items:

- Fixed class not found warning on the Doctrine ObjectManager
- Twig was locked to version 3.0
- updated travis.yaml file to support testing multiple symfony versions against multiple php versions
- updated travis.yaml file: composer cache fixed
@Matth--
Copy link
Collaborator Author

Matth-- commented Dec 9, 2020

@Bukashk0zzz

Ok I squashed the commits and this PR is no longer a WIP.

@Bukashk0zzz Bukashk0zzz merged commit e8ee18e into thecatontheflat:master Dec 9, 2020
@Matth-- Matth-- deleted the fix/dependencies branch February 11, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matth-- @Bukashk0zzz