User white lists #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing white lists settings in Tenant entity
| return; | ||
| } | ||
|
|
||
| $today = date('Y-m-d'); | ||
| $whitelist = $this->kernel->getContainer()->getParameter('license_whitelist'); | ||
| foreach ($whitelist as $allowed) { |
There was a problem hiding this comment.
Thanks, I like the idea of being able to manipulate this from the DB!
Could you please cleanup the old logic of checking the params, as well as remove the relevant entries from parameters.yml.dist?
There was a problem hiding this comment.
well, current implementation allow to use "both ways" - database and parameters.yml
Leaving code for processing parameters.yml will give full backward compatibility.
So, basically, you could simply update lib and not required to change parameters.yml
Maybe lets leave that code for BC?
There was a problem hiding this comment.
Yeah, makes sense.
Thanks! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about format of parameter license_whitelist, but as for me its more easy to set white-list flags directly in database