-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #22
Refactoring #22
Conversation
Hey! This looks awesome, thank you so much for taking your time and creating the PR! The only concern I have is escaping the native functions such as Is specifying global namespace for those functions really necessary? |
@thecatontheflat Starting from 7.1 this is important for opcache optimization |
Thanks a lot for this! |
Created 2.0.0 tag |
@thecatontheflat Can you please add
Your repo not in organization so I can't do this. |
Also thanks for merging. |
@Bukashk0zzz Could you do this if I added you to the co-owners of this repo? |
https://travis-ci.org -- not sure but others think yes. |
Activated this project on Travis, sent you a Collaborator's invite Cheers! |
@thecatontheflat Thank you. |
Hi,
Pull request contains:
If you agree with this changes. It will be good if you give me write access to this repo. I will add more linters for this project + will add some checks in configuration.
If you think so big changes not good idea thats ok. I will do all the things in my fork.