Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add show_change_link to grappelli_inline_tabular #174

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

Safrone
Copy link
Contributor

@Safrone Safrone commented Apr 29, 2020

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files          19       19           
  Lines        2362     2362           
=======================================
  Hits         1957     1957           
  Misses        405      405           
Flag Coverage Δ
#javascript 79.40% <ø> (ø)
#python 88.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384547f...5fee72c. Read the comment docs.

@fdintino
Copy link
Member

Thank you for this!

It looks like grappelli_stacked.html needs this fix as well. Do you think you could add that?

add show_change_link to greppelli_stacked.html
@Safrone
Copy link
Contributor Author

Safrone commented Apr 29, 2020

@fdintino Thanks for catching that. I updated the PR

@demerzel21
Copy link

This would be great!

@fdintino fdintino merged commit 5fee72c into theatlantic:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants