[pytest]: Check for duplicate intfs (sonic-net#1949)

When creating virtual servers, before a network interface into the DVS network namespace, check if that interface name is already used in the DVS namespace. If it is, delete it before moving the new interface.

Signed-off-by: Lawrence Lee <[email protected]>

tests/conftest.py

@@ -183,6 +183,12 @@ def __init__(self, ctn_name: str, pid: int, i: int):
                 f"ip netns exec {self.nsname} ip link add {self.nsname[0:12]}"
                 f" type veth peer name {self.pifname}"
             )
+
+            # ensure self.pifname is not already an interface in the DVS net namespace
+            rc, _ = subprocess.getstatusoutput(f"nsenter -t {pid} -n ip link show | grep '{self.pifname}@'")
+            if not rc:
+                ensure_system(f"nsenter -t {pid} -n ip link delete {self.pifname}")
+
             ensure_system(f"ip netns exec {self.nsname} ip link set {self.pifname} netns {pid}")
 
             # bring up link in the virtual server