Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Code refactor #58

Merged
merged 12 commits into from
Dec 23, 2018
Merged

Conversation

amrit-choudhary
Copy link
Contributor

Changes: Part 1 of code refactor. Moved files to appropriate folders and corrected references. Now has a better folder structure. Part 2 will involve actual code refactor, reducing global vars etc.

Copy link
Owner

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amrit-choudhary
Copy link
Contributor Author

if it's necessary, i will add it back again

@thealphadollar
Copy link
Owner

thealphadollar commented Dec 21, 2018 via email

@amrit-choudhary amrit-choudhary changed the title Change: Code refactor WIP: Change: Code refactor Dec 21, 2018
@amrit-choudhary amrit-choudhary changed the title WIP: Change: Code refactor Change: Code refactor Dec 21, 2018
@thealphadollar
Copy link
Owner

Great work, have you tested this thoroughly?

@amrit-choudhary
Copy link
Contributor Author

amrit-choudhary commented Dec 22, 2018

Yes, the features are working fine.

@thealphadollar
Copy link
Owner

Sorry for the delay, I'm sick.

@thealphadollar thealphadollar merged commit 38fa233 into thealphadollar:master Dec 23, 2018
@amrit-choudhary
Copy link
Contributor Author

@thealphadollar no issues; get well soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants