-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Code refactor #58
Merged
thealphadollar
merged 12 commits into
thealphadollar:master
from
amrit-choudhary:feature
Dec 23, 2018
Merged
Change: Code refactor #58
thealphadollar
merged 12 commits into
thealphadollar:master
from
amrit-choudhary:feature
Dec 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thealphadollar
requested changes
Dec 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
if it's necessary, i will add it back again |
Please do since imports are dependent on the way the game is launched.
…On Fri, Dec 21, 2018 at 12:54 PM Amrit Choudhary ***@***.***> wrote:
if it's necessary, i will add it back again
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfStIEZzcTH2M7rfqjQCAPG4jCVRV1x4ks5u7IyqgaJpZM4ZcLAS>
.
|
Great work, have you tested this thoroughly? |
Yes, the features are working fine. |
thealphadollar
approved these changes
Dec 23, 2018
Sorry for the delay, I'm sick. |
@thealphadollar no issues; get well soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: Part 1 of code refactor. Moved files to appropriate folders and corrected references. Now has a better folder structure. Part 2 will involve actual code refactor, reducing global vars etc.