-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Tests for http, https & ssh remotes #25
base: develop
Are you sure you want to change the base?
Conversation
…pore_ci into feature/ssh_remotes_parsing
Could you test out the latest develop branch? If that works for you we can close this PR. |
As far as I can see, you have already implemented a feature to parse & handle ssh remotes through Somethings to consider:
return cls(
repo=repo,
branch=repo.branch,
sha=repo.sha,
) I have tested the changes on my Ubuntu 22.04 setup. The unit tests gave me all greens inside container. |
I'll try and answer some of the queries:
|
As mentioned in #18 :
Repo
class has been extended with 3 private methods: for obtaining remote URL, for parsing & validation and for ssh-to-https conversion (these functionalities should be available for all kinds of Repo instances),piepline
now includes another parameter calledremote_url
which is passed to thefactory
method.It was tested both by running testes manually and by usage in my Gitea instance.