Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safary: negative tabindexes are invisible for Lock #33

Closed
theKashey opened this issue Jul 10, 2018 · 3 comments
Closed

Safary: negative tabindexes are invisible for Lock #33

theKashey opened this issue Jul 10, 2018 · 3 comments

Comments

@theKashey
Copy link
Owner

There is no way to "select nothing" in Safary - in case of moving focus to the body - it will be returned to the first element.
@theKashey
Copy link
Owner Author

Not reproducible in storybooks

@theKashey theKashey changed the title Safary: persistentFocus is always enabled Safary: negative tabindexes are invisible for Lock Jul 15, 2018
@theKashey
Copy link
Owner Author

  • tabIndex -1 makes component FOCUSABLE, but not "tabbable".
  • you can click on it, and it will become document.activeElement.
  • but will not be ":focused" in Safari 🤷‍♂️

problem is with focusInside function which returns false if focus is on "unfocusable" element.

theKashey added a commit that referenced this issue Jul 15, 2018
@theKashey
fix: Safary and Negative TabIndex, #33
f4a6a6d
@theKashey
Copy link
Owner Author

Fixed in 1.11.2

  • still a problem for vue/dom locks.

nickspaargaren pushed a commit to nickspaargaren/react-focus-lock that referenced this issue Dec 11, 2024
@theKashey
fix: Safary and Negative TabIndex, theKashey#33
5d51e9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theKashey