Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to styled components issue #1

Merged
merged 1 commit into from
May 11, 2020
Merged

link to styled components issue #1

merged 1 commit into from
May 11, 2020

Conversation

avindra
Copy link
Contributor

@avindra avindra commented May 11, 2020

The issue on styled components gives a little more context, and the original fix is linked to

The issue on styled components gives a little more context, and the [original fix](styled-components/styled-components#1022) is linked to
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            8         8           
  Branches         2         2           
=========================================
  Hits             8         8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe60210...8202991. Read the comment docs.

@theKashey
Copy link
Owner

Would it be better to link issue - styled-components/styled-components#887?
The bigger part of linked PR is more about tests/code, not about CSP itself.

@avindra
Copy link
Contributor Author

avindra commented May 11, 2020

@theKashey actually the issue is the thing linked 👍 I only mentioned the PR in the comment / description. Sorry for confusion

@theKashey
Copy link
Owner

👍

@theKashey theKashey merged commit 6e7d3e9 into theKashey:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants