Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVB-1999] Integrate Zenodo API #691

Open
wants to merge 106 commits into
base: master
Choose a base branch
from
Open

[TVB-1999] Integrate Zenodo API #691

wants to merge 106 commits into from

Conversation

abhi-glitchhg
Copy link
Collaborator

No description provided.

abhi-glitchhg and others added 30 commits May 12, 2023 19:29
…l just focus on the downloading functionality. If required searching functionalities can be added
merging to check if ci is happy and green.
Fixing the dataloading for "edited_connectivity"
removing tvb_data library dependency
@abhi-glitchhg abhi-glitchhg changed the title [TVB-1990] Integrate Zenodo API [TVB-1999] Integrate Zenodo API Aug 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

86.1% 86.1% Coverage
0.0% 0.0% Duplication

@liadomide
Copy link
Member

We would need here:

  • a good review of the code changed
  • fixing conflicts (maybe with a rebase?)
  • evaluate if performance is ok after these changes (e.g. no drop in perf for running all tests)
  • is the new API clear enough ?
  • if all good, them merge

@abhi-glitchhg
Copy link
Collaborator Author

Hey lia,

let me know if you need any help from my side. I would be happy to help.

😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants