Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster history updater #393

Closed
wants to merge 4 commits into from
Closed

Faster history updater #393

wants to merge 4 commits into from

Conversation

maedoc
Copy link
Member

@maedoc maedoc commented Apr 3, 2021

This reduces by 4x the time spent in Simulator._loop_history_update during a surface simulation, by caching useful data and applying an in-place parallelized update algorithm.

This is currently a draft since the code changes are not entirely well placed, the new algorithm assumes 1 mode and it also assumes region indices are contiguous in the regmap.

@maedoc maedoc marked this pull request as draft April 3, 2021 15:01
@maedoc maedoc self-assigned this Oct 26, 2021
@maedoc
Copy link
Member Author

maedoc commented Oct 26, 2021

This PR should handle a few more things before being considered complete:

  • possibly reordering the region mapping to ensure contiguity
  • caching the bin counts in a suitable place
  • generating equivalent code for surface in code gen backends

@maedoc
Copy link
Member Author

maedoc commented Apr 28, 2022

Marked in #555 as something requiring further work. Closing PR for now.

@maedoc maedoc closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant