-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added debian directory for building debian package #80
base: trunk
Are you sure you want to change the base?
Conversation
Override all lintian false errors
Downgrade matplotlib to 2.1.2 because _cntr is missing in 2.1.2 later versions and tvb-framework need it in order to run with raise ImportError: cannot import name _cntr if not included.
@umarbrowser good job. What commands should I run to build this deb? |
dpkg-buildpackage -rfakeroot -us -i -I or shortly install debuild and call it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should adjust to the latest master branch and fix the recent commented stuff bellow
python-sklearn, | ||
python-scipy, | ||
tvb-gdist, | ||
tvb-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to use python3-* packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove tvb-data from dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add pytest to be able to run unittests at package build time
verify that they do run at package build time, if not, adjust debian/rules accordingly with override_dh_auto_test:
rule which would trigger/run the tests
tvb-data | ||
Standards-Version: 4.1.4 | ||
Vcs-Browser: https://github.com/the-virtual-brain/tvb-library | ||
Vcs-Git: https://github.com/the-virtual-brain/tvb-library.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you keep packaging in a dedicated debian branch (which would merge releases from master branch, as recommended by @yarikoptic), then add here the option to git -b debian
Vcs-Git: https://github.com/the-virtual-brain/tvb-library.git | ||
Homepage: http://www.thevirtualbrain.org | ||
|
||
Package: tvb-library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO -- check how to properly name this, might want to become python3-tvb
(python3-tvb-library
) and the framework one could be named either just a simple tvb
or tvb-framework
Architecture: all | ||
Depends: ${misc:Depends}, | ||
${python:Depends} | ||
Description: most important scientific contribution of TVB Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description: most important scientific contribution of TVB Project | |
Description: the core library of the TVB Project |
@@ -0,0 +1,2 @@ | |||
tvb-library: no-upstream-changelog | |||
tvb-library: dependency-on-python-version-marked-for-end-of-life |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove upon migration to provide python3 packages
@@ -44,7 +44,7 @@ | |||
|
|||
TVB_TEAM = "Stuart Knock, Marmaduke Woodman, Paula Sanz Leon, Laurent Pezard, Viktor Jirsa" | |||
|
|||
TVB_INSTALL_REQUIREMENTS = ["networkx", "numpy", "numba", "numexpr", "matplotlib", | |||
TVB_INSTALL_REQUIREMENTS = ["networkx", "numpy", "numba", "numexpr", "matplotlib==2.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove version restriction
Would be good to take this up again in the tvb-root repo so we could coordinate the Debian packages. |
Override all lintian false errors and clean it