Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added debian directory for building debian package #80

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Added debian directory for building debian package #80

wants to merge 7 commits into from

Conversation

umarbrowser
Copy link

Override all lintian false errors and clean it

Override all lintian false errors
Downgrade matplotlib to 2.1.2 because _cntr is missing in 2.1.2 later versions and tvb-framework need it in order to run with raise ImportError: cannot import name _cntr if not included.
@maedoc
Copy link
Member

maedoc commented Jul 16, 2019

@umarbrowser good job. What commands should I run to build this deb?

@umarbrowser
Copy link
Author

dpkg-buildpackage -rfakeroot -us -i -I

or shortly install debuild and call it.

Copy link
Member

@liadomide liadomide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should adjust to the latest master branch and fix the recent commented stuff bellow

python-sklearn,
python-scipy,
tvb-gdist,
tvb-data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to use python3-* packages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove tvb-data from dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add pytest to be able to run unittests at package build time
verify that they do run at package build time, if not, adjust debian/rules accordingly with override_dh_auto_test: rule which would trigger/run the tests

tvb-data
Standards-Version: 4.1.4
Vcs-Browser: https://github.com/the-virtual-brain/tvb-library
Vcs-Git: https://github.com/the-virtual-brain/tvb-library.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you keep packaging in a dedicated debian branch (which would merge releases from master branch, as recommended by @yarikoptic), then add here the option to git -b debian

Vcs-Git: https://github.com/the-virtual-brain/tvb-library.git
Homepage: http://www.thevirtualbrain.org

Package: tvb-library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO -- check how to properly name this, might want to become python3-tvb (python3-tvb-library) and the framework one could be named either just a simple tvb or tvb-framework

Architecture: all
Depends: ${misc:Depends},
${python:Depends}
Description: most important scientific contribution of TVB Project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Description: most important scientific contribution of TVB Project
Description: the core library of the TVB Project

@@ -0,0 +1,2 @@
tvb-library: no-upstream-changelog
tvb-library: dependency-on-python-version-marked-for-end-of-life
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove upon migration to provide python3 packages

@@ -44,7 +44,7 @@

TVB_TEAM = "Stuart Knock, Marmaduke Woodman, Paula Sanz Leon, Laurent Pezard, Viktor Jirsa"

TVB_INSTALL_REQUIREMENTS = ["networkx", "numpy", "numba", "numexpr", "matplotlib",
TVB_INSTALL_REQUIREMENTS = ["networkx", "numpy", "numba", "numexpr", "matplotlib==2.1.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove version restriction

@maedoc
Copy link
Member

maedoc commented Feb 6, 2020

Would be good to take this up again in the tvb-root repo so we could coordinate the Debian packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants