-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OwLab Suit80 #953
Conversation
bump |
There is nothing to bump here. The QMK PR for this keyboard is not yet merged into master. You apparently even failed to properly read what the template says.
This MANDATORY is not there as a joke. |
The files in that gist aren't correct either... |
Modified |
ISO layout file is still wrong... |
Thanks for the feedback. It'd help if you could add a short note why, so we don't duplicate effort - you find the mistake, then I try to find the mistake. |
I'm talking directly with the Owlab guys on Discord (I worked with them before). There are also plenty of other TKLs in this repo that you can use as a reference how a correct json should look like. |
ISO file modified. |
Already modified, please check |
@kb-elmo do I merge or not? |
Yeah looks fine I think 😄 |
Description
QMK Pull Request
Checklist
0xFEED