Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OwLab Suit80 #953

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Add support for OwLab Suit80 #953

merged 4 commits into from
Nov 5, 2021

Conversation

owlab-git
Copy link
Contributor

@owlab-git owlab-git commented Sep 17, 2021

Description

QMK Pull Request

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@owlab-git
Copy link
Contributor Author

bump

@str-dst
Copy link
Contributor

str-dst commented Sep 17, 2021

There is nothing to bump here.

The QMK PR for this keyboard is not yet merged into master.
Which you btw failed to link to in this PR (which is very clearly listed as a requirement in the template).
qmk/qmk_firmware#14362

You apparently even failed to properly read what the template says.

The VIA support for this keyboard is in QMK master already (MANDATORY)

This MANDATORY is not there as a joke.
You marked this off as complete even though it isn't

@owlab-git owlab-git closed this Sep 17, 2021
@owlab-git owlab-git reopened this Sep 17, 2021
@str-dst
Copy link
Contributor

str-dst commented Sep 29, 2021

Updated definitions with colors per VIA's KLE JSON rules, see this gist. Nice board!

The files in that gist aren't correct either...

@owlab-git
Copy link
Contributor Author

Modified

@str-dst
Copy link
Contributor

str-dst commented Sep 29, 2021

ISO layout file is still wrong...

@gknapp
Copy link
Contributor

gknapp commented Sep 30, 2021

Thanks for the feedback. It'd help if you could add a short note why, so we don't duplicate effort - you find the mistake, then I try to find the mistake.

@str-dst
Copy link
Contributor

str-dst commented Sep 30, 2021

Thanks for the feedback. It'd help if you could add a short note why, so we don't duplicate effort - you find the mistake, then I try to find the mistake.

I'm talking directly with the Owlab guys on Discord (I worked with them before).
That's why I didn't add the fixed jsons here.

There are also plenty of other TKLs in this repo that you can use as a reference how a correct json should look like.

For the ISO version the correct layout would look like this
preview

@owlab-git
Copy link
Contributor Author

ISO file modified.

@owlab-git
Copy link
Contributor Author

Already modified, please check

@wilba
Copy link
Contributor

wilba commented Nov 2, 2021

@kb-elmo do I merge or not?

@wilba wilba added the question Further information is requested label Nov 2, 2021
@str-dst
Copy link
Contributor

str-dst commented Nov 5, 2021

@kb-elmo do I merge or not?

Yeah looks fine I think 😄

@wilba wilba merged commit 89c09c5 into the-via:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants