Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CFTKB Mysterium and Discipad VIA support #94

Merged
merged 4 commits into from
Apr 28, 2020

Conversation

brandonschlack
Copy link
Contributor

Description

Adds CFTKB Mysterium and Discipad to VIA, based on the maintainer @coseyfannitutti previous work with the Discipline and Romeo. Both have been tested on devices with the VIA Design tab.

QMK Pull Request

qmk/qmk_firmware#8794

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@wilba
Copy link
Contributor

wilba commented Apr 14, 2020

Mysterium KLE doesn't have all the "modifier" keys with "modifier" color... arrows, nav keys, F keys, system keys, backspace.

The aim is to make them look like a standard keyset with two colors, often referred to as "alphas" and "modifiers". Accents for Esc, Enter, arrows, etc. are optional.

https://caniusevia.com/docs/layouts#kle-json-rules

@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Apr 14, 2020
@brandonschlack
Copy link
Contributor Author

Fixed issues with discipad formatting and mysterium modifier color.

@wilba wilba merged commit 8174ba3 into the-via:master Apr 28, 2020
@brandonschlack brandonschlack deleted the cftkb_mysterium_discipad branch April 28, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants