Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maartenwut Wasdat #90

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Add Maartenwut Wasdat #90

merged 3 commits into from
Apr 13, 2020

Conversation

fauxpark
Copy link
Contributor

Description

image

QMK Pull Request

qmk/qmk_firmware#8762

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@wilba
Copy link
Contributor

wilba commented Apr 12, 2020

The KLE is missing some mod colors

The "no numpad" layout option group (keys with decal state on) don't need matrix coordinates in the labels.

@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Apr 12, 2020
@fauxpark
Copy link
Contributor Author

I've just set Caps Lock as a modifier. I don't consider Tab, Backslash or Backspace to be part of that group.

Good to know about the decal keys.

@wilba
Copy link
Contributor

wilba commented Apr 12, 2020

I use the term "modifier" loosely, to mean all keys that are colored the same as "modifier" keys like Shift, Control, Alt, etc. in a standard keycap set.

Example: https://cdn.shopify.com/s/files/1/3099/8088/products/[email protected]?v=1580837107

@fauxpark
Copy link
Contributor Author

fauxpark commented Apr 12, 2020

image
Looks like this now. Would be nice if the modifier keys were coloured differently to the normal keys, and perhaps a nomenclature change from "modifier" to "secondary" or something (like how the Material Design guidelines have Primary, Secondary and Accent). That's why I thought it might actually be for "proper" modifiers.

@wilba
Copy link
Contributor

wilba commented Apr 12, 2020

Yeah, they used to, before @olivia switched to GMK Olivia++ Dark theme

@wilba
Copy link
Contributor

wilba commented Apr 12, 2020

We will have configurable themes one day, I just need to keep nagging....

@wilba wilba merged commit 2b36c11 into the-via:master Apr 13, 2020
@fauxpark fauxpark deleted the wasdat-via branch April 13, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants