Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geekboards macropad_v2 #449

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

ruddy17
Copy link
Contributor

@ruddy17 ruddy17 commented Dec 9, 2020

Description

Via configs for Geekboards Macropad V2, 8-keys macropad with RGB lighting

QMK Pull Request

qmk/qmk_firmware#11045

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@ruddy17
Copy link
Contributor Author

ruddy17 commented Dec 9, 2020

@ruddy17
Copy link
Contributor Author

ruddy17 commented Dec 10, 2020

Please, check this PR in QMK: qmk/qmk_firmware#11084
Now, as it is merged, it is possible to use VIA with QMK's RGB matrix effects. For current VIA it requires some manual extensions in json config, as seen in my PR. I suggest VIA devs to implement "lighting":"qmk_rgb_matrix" option, so it integrates more seamlessly. The changes required are effect names and effect speed value range of 0..255 instead of current 0..3

@wilba
Copy link
Contributor

wilba commented Jan 14, 2021

I will merge this now, but it will require refactoring after the custom menus/UI is rolled out, i.e. after QMK's RGB matrix is properly supported in VIA through custom menus/UI.

@wilba wilba merged commit 46bd1d9 into the-via:master Jan 14, 2021
@ruddy17
Copy link
Contributor Author

ruddy17 commented Jan 14, 2021

Thank you. I'll be first in the line to pr the refactor :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants