Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ANSI layout on yd60mq #383

Merged
merged 2 commits into from
Oct 25, 2020
Merged

Fix ANSI layout on yd60mq #383

merged 2 commits into from
Oct 25, 2020

Conversation

se-bastiaan
Copy link
Contributor

@se-bastiaan se-bastiaan commented Oct 24, 2020

Description

The layout that was defined in #309 contains a small mistake that this PR tries to fix. Before the ANSI layout defined used the 4,9 identifier for all the four modifiers in the bottom right. This means that enabling this layout does not allow you to edit all the modifiers and you are stuck with the Minila layout instead:

Screenshot 2020-10-24 at 16 19 22

(RWin because I'm using my own Mac layout, this would usually be RAlt)

After this PR the keymap editor looks like this with all the keys correctly identified:

Screenshot 2020-10-24 at 16 19 42

I also took the liberty of capitalising some of the used labels and accenting the Esc and Enter keys.

QMK Pull Request

There are no changes in QMK required.

Checklist

@wilba wilba merged commit e2b475b into the-via:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants