Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kbd19x support; Add B.mini Support #349

Closed
wants to merge 6 commits into from
Closed

Add kbd19x support; Add B.mini Support #349

wants to merge 6 commits into from

Conversation

fatb0y
Copy link

@fatb0y fatb0y commented Oct 3, 2020

Description

Add kbd19x json

QMK Pull Request

qmk/qmk_firmware#10527

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@fatb0y fatb0y changed the title Add kbd19x json Add kbd19x support Oct 7, 2020
@fatb0y fatb0y changed the title Add kbd19x support Add kbd19x support; Add B.mini Support Oct 7, 2020
@2Moons-JP
Copy link
Contributor

Also qmk/qmk_firmware#10401

2Moons-JP
2Moons-JP reviewed Oct 9, 2020
View reviewed changes
src/kbdfans/kbd19x/kbd19x.json
"x": 15.75,
"c": "#aaaaaa"
},
"7,00\n\n\n2,1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QMK VIA keymap uses Layout_ansi. 7,00 for split backspace not in Layout_ansi in QMK. May want to change QMK VIA keymap to use Layout_all.

@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Oct 19, 2020
@wilba
Copy link
Contributor

wilba commented Jan 11, 2021

This PR is blocked and will not be looked at again until it is merged into QMK, the PRs for the merge are referenced here, and someone bumps this PR.

@wilba wilba added the blocked label Jan 11, 2021
@wilba wilba closed this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2Moons-JP 2Moons-JP 2Moons-JP left review comments

Assignees
No one assigned
Labels
blocked pending QMK merge Waiting for merge into QMK master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fatb0y @2Moons-JP @wilba