Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a KLE json for keebio viterbi rev 2 #305

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Conversation

TheLibra23
Copy link
Contributor

@TheLibra23 TheLibra23 commented Sep 12, 2020

Added a KLE json for keebio viterbbi rev 2

Description

added a viterbi-rev2.json file to enable via support

QMK Pull Request

qmk/qmk_firmware#10168

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

to enable full via support for viterbi revision 2 keyboard by keeb.io
added a KLE.json file for viterbi revision 2 keyboard.
@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Sep 15, 2020
@wilba
Copy link
Contributor

wilba commented Sep 15, 2020

Requires QMK PR

@TheLibra23 TheLibra23 closed this Sep 15, 2020
@TheLibra23 TheLibra23 reopened this Sep 15, 2020
@TheLibra23
Copy link
Contributor Author

Requires QMK PR

Already edited it with the qmk pr link. Thanks and regards.

@wilba
Copy link
Contributor

wilba commented Sep 15, 2020

You only need to do layout options for the parts that are different, e.g.

image

Changed default layout to 2u space.
Removed what Wilba6582 told me to remove.
@TheLibra23
Copy link
Contributor Author

You only need to do layout options for the parts that are different, e.g.

image

Hi already changed the default layout to 2u space and removed the things you told me to remove. Thank you.

@TheLibra23
Copy link
Contributor Author

You only need to do layout options for the parts that are different, e.g.

image

And the via keymap for qmk has also been merged.
https://github.com/qmk/qmk_firmware/tree/master/keyboards/keebio/viterbi/keymaps/via

@wilba wilba merged commit d49a5aa into the-via:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants