Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new BAMFK-1 Rev. 1 definition #2183

Merged
merged 1 commit into from
May 31, 2024
Merged

Add new BAMFK-1 Rev. 1 definition #2183

merged 1 commit into from
May 31, 2024

Conversation

nooges
Copy link
Contributor

@nooges nooges commented Mar 7, 2024

Description

  • Adds support for encoder map and RGB matrix

QMK Pull Request

qmk/qmk_firmware#23236

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@nooges nooges marked this pull request as ready for review May 28, 2024 15:23
@nooges
Copy link
Contributor Author

nooges commented May 28, 2024 •
edited
Loading

Ready for review now that QMK develop has been merged into master

@Xelus22 Xelus22 merged commit d5f3a84 into the-via:master May 31, 2024
2 checks passed
@nooges nooges deleted the bamfk-1 branch May 31, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nooges @Xelus22