Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyboard bestway #2093

Merged
merged 3 commits into from
Feb 3, 2024
Merged

add keyboard bestway #2093

merged 3 commits into from
Feb 3, 2024

Conversation

LXF-YZP
Copy link
Contributor

@LXF-YZP LXF-YZP commented Dec 1, 2023

Description

add keyboard bestway

QMK Pull Request

qmk/qmk_firmware/pull/22498

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@@ -0,0 +1,305 @@
{
"name": "Best70",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename file to bestway.json

The name is Best70 but in QMK it says just Best.
Please keep one of them to be consistent

v3/bestway/best.json Outdated Show resolved Hide resolved
@Xelus22 Xelus22 merged commit d438035 into the-via:master Feb 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants