Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Soulstone keyboard #2054

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Add Soulstone keyboard #2054

merged 1 commit into from
Oct 22, 2023

Conversation

Strech
Copy link
Contributor

@Strech Strech commented Oct 18, 2023

Description

Add support for the Soulstone keyboard

QMK Pull Request

qmk/qmk_firmware#22093

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Strech
Copy link
Contributor Author

Strech commented Oct 18, 2023

I've tested both firmware and design, flashed keyboard and it's working as expected 👍🏼

VIA 2023-10-18 11-35-32
Keyboard Layout Editor 2023-10-18 11-28-07

@Xelus22 Xelus22 merged commit b2128c7 into the-via:master Oct 22, 2023
2 checks passed
@Strech
Copy link
Contributor Author

Strech commented Oct 25, 2023

Thanks @Xelus22, very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strech @Xelus22