Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIA support for redragon k667 #2028

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Conversation

temp4gh
Copy link
Contributor

@temp4gh temp4gh commented Sep 26, 2023

Description

Add VIA support for redragon k667 and request for a review, thanks!

QMK Pull Request

qmk/qmk_firmware#21917

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@temp4gh temp4gh requested a review from Xelus22 October 7, 2023 09:13
@temp4gh
Copy link
Contributor Author

temp4gh commented Oct 7, 2023

https://www.caniusevia.com/docs/layouts#kle-json-rules

Colour in KLE please

Modified and committed .Thanx!

@Xelus22 Xelus22 merged commit f5f54ea into the-via:master Oct 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants