Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for TAN67 PCB #1992

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Adding support for TAN67 PCB #1992

merged 5 commits into from
Sep 11, 2023

Conversation

Pangorin
Copy link
Contributor

Description

Adding VIA keymap support for TAN67 PCB

QMK Pull Request

qmk/qmk_firmware#21003

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Pangorin
Pangorin commented Aug 20, 2023
View reviewed changes
Copy link
Contributor Author

@Pangorin Pangorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layouts

@Xelus22
Copy link
Collaborator

Xelus22 commented Aug 26, 2023

I believe these 3 keys are arrows? Should be white?
image

Pangorin
Pangorin commented Aug 26, 2023
View reviewed changes
Copy link
Contributor Author

@Pangorin Pangorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the layout.

@Pangorin
Copy link
Contributor Author

I believe these 3 keys are arrows? Should be white? image

Yeah, I edited it!

@Xelus22
Copy link
Collaborator

Xelus22 commented Sep 2, 2023

Pleease check, build error

Xelus22
Xelus22 requested changes Sep 11, 2023
View reviewed changes
v3/pangorin/tan67/tan67.json Outdated Show resolved Hide resolved
@Pangorin Pangorin requested a review from Xelus22 September 11, 2023 08:53
@Xelus22 Xelus22 merged commit 4d767f7 into the-via:master Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pangorin @Xelus22