Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linworks fave60a json #1855

Merged
merged 4 commits into from
Oct 2, 2023
Merged

add linworks fave60a json #1855

merged 4 commits into from
Oct 2, 2023

Conversation

duilchoi
Copy link
Contributor

@duilchoi duilchoi commented May 8, 2023

add fave60a json

Description

hi.
i added linworks fave60a json.
please review.

QMK Pull Request

qmk/qmk_firmware#20795

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

add fave60a json
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Missing a few keys colour

@duilchoi duilchoi requested a review from Xelus22 October 2, 2023 02:53
@Xelus22 Xelus22 merged commit 8d7a081 into the-via:master Oct 2, 2023
2 checks passed
j4ckofalltrades pushed a commit to j4ckofalltrades/via-keyboards that referenced this pull request Oct 18, 2023
* [Core] Update the-via/reader dependency to 1.8.0 (the-via#2032)

* Update zed65-rev1.json (the-via#2024)

correct matrix position for "LAYOUTS/Bottom Row/Full Space 7U and Space 6.25U

* Update odinmini layout (the-via#2026)

* add dz60v2 keyboard (the-via#2027)

* Add VIA support for Treasure TYPE-9 Series III (the-via#2016)

Co-authored-by: Xelus22 <[email protected]>

* update super16v3.json (the-via#2031)

* Add support for Span (the-via#2034)

* Update galatea-rev1.json

* Update galatea-rev2.json

* Add via support for Galatea rev3 (the-via#2033)

* Update galatea-rev3.json

* Update i160h.json

* Update i160s.json

* Update sinc-rev1a.json

* Update sinc-rev2a.json

* add linworks fave60a json (the-via#1855)

* add momokai aurora (the-via#2029)

* Bastard Keyboards: Add Dilemma Max and Charybdis Mini (the-via#2039)

* add linworks favepada json (the-via#1856)

* Add SyenaKeyboards (the-via#2037)

Co-authored-by: Syenasweta <[email protected]>

* Add VIA support for Drop CSTM80 (the-via#2041)

* Add handwired ziyoulang_k3_mod (the-via#2042)

* Create the split67 keyboard configuration (the-via#2035)

Co-authored-by: “yuezp” <“[email protected]”>

* Add Graystudio Think6.5 V3 VIA support (the-via#2044)

* Update think65v3_via.json

* Nico update (the-via#2017)

* initial commit (the-via#2048)

---------

Co-authored-by: Xelus22 <[email protected]>
Co-authored-by: mechlovin <[email protected]>
Co-authored-by: dztech <[email protected]>
Co-authored-by: TreasureTypes <[email protected]>
Co-authored-by: ziptyze <[email protected]>
Co-authored-by: Idan Kamara <[email protected]>
Co-authored-by: studiokestra <[email protected]>
Co-authored-by: DUILCHOI <[email protected]>
Co-authored-by: peepeetee <[email protected]>
Co-authored-by: casuanoob <[email protected]>
Co-authored-by: Syenasweta a.k.a. Nashrullah Ali Fauzi <[email protected]>
Co-authored-by: Syenasweta <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Coom <[email protected]>
Co-authored-by: yuezp <[email protected]>
Co-authored-by: “yuezp” <“[email protected]”>
Co-authored-by: Yizhen Liu <[email protected]>
Co-authored-by: yulei <[email protected]>
Co-authored-by: Josh Hinnebusch <[email protected]>
@duilchoi duilchoi deleted the b_fave60a branch October 30, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants