Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoders to keyboard definition for Keebio KBO-5000 #1792

Closed
wants to merge 1 commit into from
Closed

Add encoders to keyboard definition for Keebio KBO-5000 #1792

wants to merge 1 commit into from

Conversation

raphkris
Copy link

Description

  • Added encoders to keyboard definition and layout options.
  • Changed typo in layout label for Right Shift from 1.75u to 2.75u.
  • Changed color of arrow keys to #777777.
  • Removed stepped caps from keyboard definition (and layout options) per KLE JSON rules.
  • Updated bottom-right legends of layout option choices to reflect changes stated above.

QMK Pull Request

qmk/qmk_firmware#20272

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@raphkris
- Added encoders to keyboard definition and layout options.
3422bc6 
- Changed layout label for Right Shift from 1.75u to 2.75u.
- Changed color of arrow keys to #777777.
- Remove stepped caps from keyboard definition (and layout options) per KLE JSON rules.
- Updated bottom-right legends of layout option choices to reflect changes.
nooges
nooges reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@nooges nooges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break compatibility with boards running the older version of the firmware. I will submit my own PR with a revised PID.

@nooges
Copy link
Contributor

nooges commented Apr 3, 2023

New PR: #1804

@Xelus22 Xelus22 closed this Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nooges nooges nooges left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raphkris @nooges @Xelus22