Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keychron Q11 #1777

Merged
merged 7 commits into from
Apr 8, 2023
Merged

Add Keychron Q11 #1777

merged 7 commits into from
Apr 8, 2023

Conversation

adophoxia
Copy link
Contributor

@adophoxia adophoxia commented Mar 21, 2023 •
edited
Loading

Description

Add ansi_encoder (or in this case, ANSI Knob) variant of Keychron Q11.

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@adophoxia adophoxia requested a review from KeychronMacro April 7, 2023 02:52
KeychronMacro
KeychronMacro approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@KeychronMacro KeychronMacro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@adophoxia
Copy link
Contributor Author

Updated checklist now that the Q11 is merged into qmk/master.

@Xelus22 Xelus22 merged commit a11b617 into the-via:master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeychronMacro KeychronMacro KeychronMacro approved these changes

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adophoxia @Xelus22 @KeychronMacro