Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I found that when trying to run the given instructions, I was getting errors about not being able to find the
text_recognizer
module. Changing the instructions to invoke theemnist_dataset
as part of a package triggers the right module search path and seems to do the trick (see updated readme below).However, that then led to a runtime warning:
Commenting out the explicit call to
.emnist_dataset
indatasets/__init__.py
seems to solve that. There's probably a reason that was in there in the first place though 👀 😬Similarly, if ☝️ makes sense, the paths in https://github.com/full-stack-deep-learning/fsdl-text-recognizer-project/tree/master/lab2_sln/readme.md probably need adjusting as well. E.g.