Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/fbar 330 tabindex search #2335

Merged
merged 11 commits into from
Dec 31, 2024
Merged

Fix/fbar 330 tabindex search #2335

merged 11 commits into from
Dec 31, 2024

Conversation

Camwyn
Copy link
Member

@Camwyn Camwyn commented Dec 30, 2024

See #2230

🎫 Ticket

FBAR-330

🗒️ Description

Making select tab friendly.

🎥 Artifacts

https://www.loom.com/share/243adc4b980d429da9eed454e88543bb?sid=3050fb61-e2a5-4ac0-8581-cfef87ce97fe

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@Camwyn Camwyn added the code review Status: requires a code review. label Dec 30, 2024
@Camwyn Camwyn requested a review from stratease December 30, 2024 17:46
stratease
stratease approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@stratease stratease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@Camwyn Camwyn merged commit 3b6d19f into release/T25.imp Dec 31, 2024
17 of 18 checks passed
@Camwyn Camwyn deleted the fix/FBAR-330-tabindex-search branch December 31, 2024 14:48
stratease added a commit that referenced this pull request Jan 14, 2025
@stratease
Revert "Merge pull request #2335 from the-events-calendar/fix/FBAR-33…
ba2dd6d 
…0-tabindex-search"

This reverts commit 3b6d19f, reversing
changes made to 4d3f741.
stratease added a commit that referenced this pull request Jan 14, 2025
@stratease
Merge pull request #2348 from the-events-calendar/revert/FBAR-330
de5c438 
Revert Merge pull request #2335 from the-events-calendar/fix/FBAR-330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratease stratease stratease approved these changes

Assignees

@stratease stratease

Labels
code review Status: requires a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Camwyn @stratease