Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ET-2297] Add Booking Fees to Confirmation Emails #3558

Open
wants to merge 11 commits into
base: release/T25.batman
Choose a base branch
from

Conversation

sdokus
Copy link
Contributor

@sdokus sdokus commented Feb 12, 2025

🎫 Ticket

ET-2297

🗒️ Description

Booking Fees are not showing up as a separate line on Confirmation Emails or Purchase Receipts. The total accurately reflects the fees, but there should be more feedback about every part of the total, including the fees.

🎥 Artifacts

Before:
image

After:
CleanShot 2025-02-13 at 14 45 26@2x

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@sdokus sdokus added the hold Status: on hold–do not proceed with other status items. label Feb 12, 2025
@sdokus sdokus self-assigned this Feb 12, 2025
@sdokus sdokus added code review Status: requires a code review. and removed hold Status: on hold–do not proceed with other status items. labels Feb 13, 2025
@sdokus sdokus requested a review from a team February 13, 2025 22:22
Comment on lines +37 to +53
<?php foreach ( $fees as $fee ) : ?>
<tr>
<td class="tec-tickets__email-table-content-order-fees-name">
<?php
echo esc_html( $fee['display_name'] );
if ( isset( $fee['quantity'] ) && $fee['quantity'] > 1 ) {
printf(
/* translators: %s: Quantity of a fee */
' ' . esc_html_x( '(%sx)', 'Quantity of a fee with "x" after it, eg. "2x"', 'event-tickets' ),
esc_html( $fee['quantity'] )
);
}
?>
</td>
<td class="tec-tickets__email-table-content-order-fees-right-cell">
<?php echo esc_html( tribe_format_currency( $fee['sub_total'] ) ); ?>
</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like us to test with like 10 fees as well. is this breaking the usability of the layout then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants