-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ET-2297] Add Booking Fees to Confirmation Emails #3558
Open
sdokus
wants to merge
11
commits into
release/T25.batman
Choose a base branch
from
fix/TECTRIA-754-add-booking-fees-to-emails
base: release/T25.batman
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ET-2297] Add Booking Fees to Confirmation Emails #3558
sdokus
wants to merge
11
commits into
release/T25.batman
from
fix/TECTRIA-754-add-booking-fees-to-emails
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate for emails
dpanta94
reviewed
Feb 14, 2025
Comment on lines
+37
to
+53
<?php foreach ( $fees as $fee ) : ?> | ||
<tr> | ||
<td class="tec-tickets__email-table-content-order-fees-name"> | ||
<?php | ||
echo esc_html( $fee['display_name'] ); | ||
if ( isset( $fee['quantity'] ) && $fee['quantity'] > 1 ) { | ||
printf( | ||
/* translators: %s: Quantity of a fee */ | ||
' ' . esc_html_x( '(%sx)', 'Quantity of a fee with "x" after it, eg. "2x"', 'event-tickets' ), | ||
esc_html( $fee['quantity'] ) | ||
); | ||
} | ||
?> | ||
</td> | ||
<td class="tec-tickets__email-table-content-order-fees-right-cell"> | ||
<?php echo esc_html( tribe_format_currency( $fee['sub_total'] ) ); ?> | ||
</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like us to test with like 10 fees as well. is this breaking the usability of the layout then ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ET-2297
🗒️ Description
Booking Fees are not showing up as a separate line on Confirmation Emails or Purchase Receipts. The total accurately reflects the fees, but there should be more feedback about every part of the total, including the fees.
🎥 Artifacts
Before:
![image](https://private-user-images.githubusercontent.com/95599199/412613996-95c88706-a6c5-4e4c-9337-04b8a0e7220e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTMzOTAsIm5iZiI6MTczOTY1MzA5MCwicGF0aCI6Ii85NTU5OTE5OS80MTI2MTM5OTYtOTVjODg3MDYtYTZjNS00ZTRjLTkzMzctMDRiOGEwZTcyMjBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIwNTgxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYyNmUyOWFlZGQyNzRhNDY1YzUxYWExODE0ZGEzZDVkN2Q4OWViZjlhZGQ1YmRmZGI4NmQzY2Q0NjVjMTdlMTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wooCZmTxjT-MG0iiiE3wsA0VvYTr2XPTDhB2j1kc4k0)
After:
![CleanShot 2025-02-13 at 14 45 26@2x](https://private-user-images.githubusercontent.com/95599199/413075260-cd3b24a5-69a1-4ead-81e4-fa00061b17da.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTMzOTAsIm5iZiI6MTczOTY1MzA5MCwicGF0aCI6Ii85NTU5OTE5OS80MTMwNzUyNjAtY2QzYjI0YTUtNjlhMS00ZWFkLTgxZTQtZmEwMDA2MWIxN2RhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIwNTgxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzZDk2N2U1NGViZmJhMzkzYjU3YmE5NGM2N2M4MThiNjQ0ZGU5OTcyZDdhZTcwODczZTQ3ZjRjN2UwNWViZTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ilRB6pkp-gji2SltmYqwJeFph7frMFYMVb2Pxx7ej0g)
✔️ Checklist
npm run changelog
to add changelog file(s). More info herewpunit
orintegration
tests.wpunit
orintegration
tests.