feat: default handler in createReducer #153

Jazzmanpw · 2020-09-17T21:44:35Z

related to #152

Release v3.2.0 and v3.1.0

Release v3.2.1

related to the-dr-lazy#152

It's ugly though. We'll try to find another way to type this

codecov · 2020-09-18T10:31:17Z

Codecov Report

Merging #153 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines           56        58    +2     
  Branches         9        10    +1     
=========================================
+ Hits            56        58    +2

Impacted Files	Coverage Δ
src/create-handler-map.ts	`100.00% <100.00%> (ø)`
src/create-reducer.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9925130...7258ef7. Read the comment docs.

Jazzmanpw · 2020-09-18T19:41:29Z

@the-dr-lazy, it seems to fail on running yarn run docs:build, but locally it works fine (it doesn't crush at least).
I found an article in Netlify blog about such crushes, but I'm not sure if I should tweak your CI. May I ask you to check what's wrong?
This is the link to the post I found. This and some other similar posts say that errors are caused by yarn.lock/package-lock.json and some wrong stuff with node_modules committed to the repo, but I didn't change anything about the project dependencies.

src/create-handler-map.ts

the-dr-lazy · 2020-09-20T15:56:39Z

What is your opinion about renaming handleAction.default into handleAction.otherwise? I think the default word can become ambiguous with default state in Redux and users think it will call when the state is equal to the default state they have sent in reducer.
Looks like otherwise makes much more sense here.

the-dr-lazy · 2020-09-20T16:11:46Z

@the-dr-lazy, it seems to fail on running yarn run docs:build, but locally it works fine (it doesn't crush at least).

The issue has been fixed in the next branch by 8df47a0.

Jazzmanpw · 2020-09-26T10:48:17Z

What is your opinion about renaming handleAction.default into handleAction.otherwise? I think the default word can become ambiguous with default state in Redux and users think it will call when the state is equal to the default state they have sent in reducer.
Looks like otherwise makes much more sense here.

If we may discuss it, I think, otherwise might not be the best option.
handleAction(action), handleAction(action), handleAction.otherwise
This is what we'll receive in the end. Maybe, one of these versions will be more straight-readable:
handleAction(action), handleAction(action), handleAction.others
handleAction(action), handleAction(action), handleAction.rest

As well as, my IDE suggests handle as an argument for createReducer callback. Then handle.otherwise is clear, but a little bit off the sentence. Although I'm not an English native, so my comment on readability might not be relevant for people closer to the English language.

the-dr-lazy · 2020-09-26T11:58:42Z

Thank you for your comment. I'm with handleAction.others.
Also, I think it's valuable to mention in functional programming there is a technique called wildcard for pattern matching. and Deox is a representation of pattern matching for JavaScript. This PR is trying to mention this technique.

Jazzmanpw · 2020-09-28T09:15:23Z

I've not heard about wildcard in FP, but I can see that the concept is pretty straightforward and familiar (we've all used switch ... default). Should it somehow affect the code, or is it just an idea to mention?

* introduce local InferActionFromCreator * divide CreateHandlerMap to two smaller types * better object-with-a-property handling with `Object.assign`

the-dr-lazy · 2020-10-01T19:05:07Z

Thank you for your contribution @Jazzmanpw. Nice job.

the-dr-lazy · 2020-10-01T20:01:23Z

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Jazzmanpw · 2020-10-01T22:53:13Z

Wow, wait a moment. I appreciate that my job was useful, but I haven't finished it yet. I met some troubles with using a symbol as a key in the final handler map. The typing troubles that is. I believe I should finish it first, don't I?

the-dr-lazy · 2020-10-01T23:57:55Z

As this PR was not a draft I thought your work is done. Sorry for that.
Please continue your work on another PR.

Jazzmanpw · 2020-10-03T13:58:49Z

I'm sorry about the PR status. I don't know much about it yet. I continue my work.

the-dr-lazy and others added 5 commits December 9, 2019 21:15

Merge pull request the-dr-lazy#137 from thebrodmann/next

8fe1758

Release v3.2.0 and v3.1.0

Merge pull request the-dr-lazy#142 from thebrodmann/next

d209aba

Release v3.2.1

docs: remove excess highlight

9925130

feat: default handler in createReducer

76ac533

related to the-dr-lazy#152

fix: more explicit typing to avoid TS4025

b82c9a1

It's ugly though. We'll try to find another way to type this

the-dr-lazy requested changes Sep 20, 2020

View reviewed changes

src/create-handler-map.ts Outdated Show resolved Hide resolved

src/create-handler-map.ts Outdated Show resolved Hide resolved

the-dr-lazy assigned Jazzmanpw Sep 20, 2020

the-dr-lazy added the enhancement New feature or request label Sep 20, 2020

the-dr-lazy linked an issue Sep 20, 2020 that may be closed by this pull request

Add "default" section in createReducer() #152

Closed

the-dr-lazy added this to the v3.2.2 milestone Sep 20, 2020

Jazzmanpw added 2 commits September 28, 2020 13:25

refactor: create-handler-map.ts

8ac5f37

* introduce local InferActionFromCreator * divide CreateHandlerMap to two smaller types * better object-with-a-property handling with `Object.assign`

fix: handle.others instead of handle.default

7258ef7

the-dr-lazy approved these changes Oct 1, 2020

View reviewed changes

the-dr-lazy changed the base branch from master to next October 1, 2020 19:04

the-dr-lazy merged commit f9aec53 into the-dr-lazy:next Oct 1, 2020

the-dr-lazy added the released on @next label Oct 1, 2020

the-dr-lazy modified the milestones: v3.2.2, v3.3.0 Oct 1, 2020

the-dr-lazy mentioned this pull request Oct 17, 2020

Why was Deox deprecated? #160

Closed

the-dr-lazy linked an issue Oct 17, 2020 that may be closed by this pull request

Why was Deox deprecated? #160

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: default handler in createReducer #153

feat: default handler in createReducer #153

Jazzmanpw commented Sep 17, 2020

codecov bot commented Sep 18, 2020 •

edited

Loading

Jazzmanpw commented Sep 18, 2020

the-dr-lazy commented Sep 20, 2020

the-dr-lazy commented Sep 20, 2020 •

edited

Loading

Jazzmanpw commented Sep 26, 2020

the-dr-lazy commented Sep 26, 2020 •

edited

Loading

Jazzmanpw commented Sep 28, 2020

the-dr-lazy commented Oct 1, 2020

the-dr-lazy commented Oct 1, 2020

Jazzmanpw commented Oct 1, 2020

the-dr-lazy commented Oct 1, 2020

Jazzmanpw commented Oct 3, 2020

feat: default handler in createReducer #153

feat: default handler in createReducer #153

Conversation

Jazzmanpw commented Sep 17, 2020

codecov bot commented Sep 18, 2020 • edited Loading

Codecov Report

Jazzmanpw commented Sep 18, 2020

the-dr-lazy commented Sep 20, 2020

the-dr-lazy commented Sep 20, 2020 • edited Loading

Jazzmanpw commented Sep 26, 2020

the-dr-lazy commented Sep 26, 2020 • edited Loading

Jazzmanpw commented Sep 28, 2020

the-dr-lazy commented Oct 1, 2020

the-dr-lazy commented Oct 1, 2020

Jazzmanpw commented Oct 1, 2020

the-dr-lazy commented Oct 1, 2020

Jazzmanpw commented Oct 3, 2020

codecov bot commented Sep 18, 2020 •

edited

Loading

the-dr-lazy commented Sep 20, 2020 •

edited

Loading

the-dr-lazy commented Sep 26, 2020 •

edited

Loading