Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createAction with only a type parameter results in function, which allows any arguments #143

Closed
SantoJambit opened this issue Mar 2, 2020 · 5 comments
Closed

createAction with only a type parameter results in function, which allows any arguments #143

SantoJambit opened this issue Mar 2, 2020 · 5 comments
Assignees
@SantoJambit
Labels
bug Something isn't working released on @next released on @3.2.x
Milestone
v3.2.2

Comments

@SantoJambit
Copy link
Contributor

SantoJambit commented Mar 2, 2020 •
edited by the-dr-lazy
Loading 

const myAction = createAction('MY_ACTION');
myAction('woot', 14, null, undefined); // Does not complain

This is doing the same thing as far as I can see, but it complains correctly:

export const myAction = createAction('MY_ACTION', (resolve) => () => resolve());
myAction('woot', 14, null, undefined); // Error
@the-dr-lazy the-dr-lazy added the bug Something isn't working label Mar 3, 2020
@the-dr-lazy the-dr-lazy modified the milestones: v3.2.2, v2.1.5 Mar 3, 2020
@the-dr-lazy
Copy link
Owner

@SantoJambit would you like to submit a PR for this issue?

SantoJambit added a commit to SantoJambit/deox that referenced this issue Mar 4, 2020
@SantoJambit
fix: type for plain action creator. Fixes the-dr-lazy#143
ba1f5ad
@SantoJambit
Copy link
Contributor Author

done

the-dr-lazy added a commit that referenced this issue Mar 16, 2020
@SantoJambit @the-dr-lazy
fix: type for plain action creator. (#144)
709fe60 
* fix: type for plain action creator. Fixes #143

* fix: more type tests for createActionCreator

* fix: adjustments after code review

Co-authored-by: Mohammad Hasani <[email protected]>
the-dr-lazy pushed a commit that referenced this issue Mar 16, 2020
@semantic-release-bot
chore(release): 3.2.2 [skip ci]
8888197 
## [3.2.2](v3.2.1...v3.2.2) (2020-03-16)

### Bug Fixes

* type for plain action creator. ([#144](#144)) ([709fe60](709fe60)), closes [#143](#143)
@the-dr-lazy
Copy link
Owner

🎉 This issue has been resolved in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@the-dr-lazy
Copy link
Owner

Thank you @SantoJambit for your contribution.

the-dr-lazy added a commit that referenced this issue Mar 16, 2020
@SantoJambit @the-dr-lazy
fix: type for plain action creator. (#144)
c045f7f 
* fix: type for plain action creator. Fixes #143

* fix: more type tests for createActionCreator

* fix: adjustments after code review

Co-authored-by: Mohammad Hasani <[email protected]>
the-dr-lazy added a commit that referenced this issue Oct 1, 2020
@SantoJambit @the-dr-lazy
fix: type for plain action creator. (#144)
f228b81 
* fix: type for plain action creator. Fixes #143

* fix: more type tests for createActionCreator

* fix: adjustments after code review

Co-authored-by: Mohammad Hasani <[email protected]>
the-dr-lazy pushed a commit that referenced this issue Oct 1, 2020
@semantic-release-bot @the-dr-lazy
chore(release): 3.2.2 [skip ci]
22a27bc 
## [3.2.2](v3.2.1...v3.2.2) (2020-03-16)

### Bug Fixes

* type for plain action creator. ([#144](#144)) ([709fe60](709fe60)), closes [#143](#143)
the-dr-lazy added a commit that referenced this issue Oct 1, 2020
@SantoJambit @the-dr-lazy
fix: type for plain action creator. (#144)
5a43381 
* fix: type for plain action creator. Fixes #143

* fix: more type tests for createActionCreator

* fix: adjustments after code review

Co-authored-by: Mohammad Hasani <[email protected]>
the-dr-lazy pushed a commit that referenced this issue Oct 1, 2020
@semantic-release-bot @the-dr-lazy
chore(release): 3.2.2 [skip ci]
9205364 
## [3.2.2](v3.2.1...v3.2.2) (2020-03-16)

### Bug Fixes

* type for plain action creator. ([#144](#144)) ([709fe60](709fe60)), closes [#143](#143)
@the-dr-lazy
Copy link
Owner

🎉 This issue has been resolved in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Oct 1, 2020
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
7ce91b6 
# [3.3.0](v3.2.1...v3.3.0) (2020-10-01)

### Bug Fixes

* handle.others instead of handle.default ([ffe271b](ffe271b))
* more explicit typing to avoid TS4025 ([25b78c3](25b78c3))
* type for plain action creator. ([#144](#144)) ([f228b81](f228b81)), closes [#143](#143)

### Features

* default handler in createReducer ([0b3dfcf](0b3dfcf)), closes [#152](#152)
github-actions bot pushed a commit that referenced this issue Oct 1, 2020
@semantic-release-bot
chore(release): 3.2.2 [skip ci]
3f272e3 
## [3.2.2](v3.2.1...v3.2.2) (2020-10-01)

### Bug Fixes

* type for plain action creator. ([#144](#144)) ([5a43381](5a43381)), closes [#143](#143)

### Reverts

* Revert "fix: type for plain action creator. (#144)" ([52cecce](52cecce)), closes [#144](#144)
* Revert "chore(release): 3.2.2 [skip ci]" ([2c24a35](2c24a35))
* Revert "chore(deps): bump acorn from 5.7.3 to 5.7.4 in /examples/tasks" ([8ac4f81](8ac4f81))
* Revert "test: remove redundant tests" ([f3585b0](f3585b0))
* Revert "chore(dependencies): update lockfiles" ([0807302](0807302))
* Revert "feat: default handler in createReducer" ([8dc28bb](8dc28bb))
* Revert "fix: more explicit typing to avoid TS4025" ([c1b1d23](c1b1d23))
* Revert "refactor: create-handler-map.ts" ([12f7519](12f7519))
* Revert "fix: handle.others instead of handle.default" ([0c27324](0c27324))
* Revert "ci: thanks to Circle CI sanctions!" ([b95295f](b95295f))
* Revert "test: fix unknown `default` handler" ([bc569d7](bc569d7))
@the-dr-lazy the-dr-lazy mentioned this issue Oct 1, 2020
Closed
github-actions bot pushed a commit that referenced this issue Oct 1, 2020
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
9c93e38 
# [3.3.0](v3.2.1...v3.3.0) (2020-10-01)

### Bug Fixes

* handle.others instead of handle.default ([ffe271b](ffe271b))
* more explicit typing to avoid TS4025 ([25b78c3](25b78c3))
* type for plain action creator. ([#144](#144)) ([f228b81](f228b81)), closes [#143](#143)

### Features

* default handler in createReducer ([0b3dfcf](0b3dfcf)), closes [#152](#152)
Jazzmanpw pushed a commit to Jazzmanpw/deox that referenced this issue Oct 6, 2020
@SantoJambit @the-dr-lazy @Jazzmanpw
fix: type for plain action creator. (the-dr-lazy#144)
dbbfad5 
* fix: type for plain action creator. Fixes the-dr-lazy#143

* fix: more type tests for createActionCreator

* fix: adjustments after code review

Co-authored-by: Mohammad Hasani <[email protected]>
Jazzmanpw pushed a commit to Jazzmanpw/deox that referenced this issue Oct 6, 2020
@semantic-release-bot @Jazzmanpw
chore(release): 3.2.2 [skip ci]
d2029cc 
## [3.2.2](the-dr-lazy/deox@v3.2.1...v3.2.2) (2020-03-16)

### Bug Fixes

* type for plain action creator. ([the-dr-lazy#144](the-dr-lazy#144)) ([709fe60](the-dr-lazy@709fe60)), closes [the-dr-lazy#143](the-dr-lazy#143)
Jazzmanpw pushed a commit to Jazzmanpw/deox that referenced this issue Oct 6, 2020
@semantic-release-bot @Jazzmanpw
chore(release): 3.3.0 [skip ci]
7a554d6 
# [3.3.0](the-dr-lazy/deox@v3.2.1...v3.3.0) (2020-10-01)

### Bug Fixes

* handle.others instead of handle.default ([ffe271b](the-dr-lazy@ffe271b))
* more explicit typing to avoid TS4025 ([25b78c3](the-dr-lazy@25b78c3))
* type for plain action creator. ([the-dr-lazy#144](the-dr-lazy#144)) ([f228b81](the-dr-lazy@f228b81)), closes [the-dr-lazy#143](the-dr-lazy#143)

### Features

* default handler in createReducer ([0b3dfcf](the-dr-lazy@0b3dfcf)), closes [the-dr-lazy#152](the-dr-lazy#152)
github-actions bot pushed a commit that referenced this issue Oct 9, 2020
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
10573fe 
# [3.3.0](v3.2.1...v3.3.0) (2020-10-09)

### Bug Fixes

* handle.others instead of handle.default ([ffe271b](ffe271b))
* more explicit typing to avoid TS4025 ([25b78c3](25b78c3))
* type for plain action creator. ([#144](#144)) ([f228b81](f228b81)), closes [#143](#143)

### Features

* default handler in createReducer ([0b3dfcf](0b3dfcf)), closes [#152](#152)
github-actions bot pushed a commit that referenced this issue Oct 17, 2020
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
9fc16b7 
# [3.3.0](v3.2.1...v3.3.0) (2020-10-17)

### Bug Fixes

* handle.others instead of handle.default ([ffe271b](ffe271b))
* more explicit typing to avoid TS4025 ([25b78c3](25b78c3))
* type for plain action creator. ([#144](#144)) ([f228b81](f228b81)), closes [#143](#143)
* use symbol for the `others` handler ([3aa61fe](3aa61fe))

### Features

* default handler in createReducer ([0b3dfcf](0b3dfcf)), closes [#152](#152)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SantoJambit SantoJambit

Labels
bug Something isn't working released on @next released on @3.2.x
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging a pull request may close this issue.

Release v3.3.0 the-dr-lazy/deox
2 participants
@the-dr-lazy @SantoJambit