Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReleaseOnGithub is not async safe #80

Closed
norberturkiewicz opened this issue Jul 22, 2020 · 0 comments
Closed

ReleaseOnGithub is not async safe #80

norberturkiewicz opened this issue Jul 22, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@norberturkiewicz
Copy link
Contributor

Asset upload needs to wait on result of upload.

Let upload start in thread and wait for result with .Result

     _←{
         f←File.OpenRead⊂⍵
         au←⎕NEW ReleaseAssetUpload
         au.FileName←∊1↓⎕NPARTS ⍵
         au.ContentType←gct ⍵
         au.RawData←f
         resultUpload←c.Repository.Release.UploadAsset(release au)
         _←⎕DL 1
         _←resultUpload.Result
         0
     }¨u
@norberturkiewicz norberturkiewicz added the bug Something isn't working label Jul 22, 2020
norberturkiewicz added a commit that referenced this issue Jul 22, 2020
@norberturkiewicz
Prerelease fixes
3556dc4 
#80
#78
#75
#70
norberturkiewicz added a commit that referenced this issue Jul 22, 2020
@norberturkiewicz
Prerelease fixes
26d5ca8 
#80
#78
#75
#70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@norberturkiewicz