Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #18

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Update dependencies #18

merged 2 commits into from
Nov 17, 2022

Conversation

LuighiV
Copy link
Contributor

@LuighiV LuighiV commented Nov 16, 2022

Describe what's being changed

Recently we had problems when trying to build a project that use this module with a recent version of react (18.2.0). Then we realize that this uses a previous mayor version of it and doesn't recognize the most updated.

The changes are:

  • Change the react-scripts version from 5.0.0 to 5.0.1
  • Allow to use as peerDependencies either the react ^17.0.2 or ^18
  • Update lock files for recent versions of dependencies

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@olavoparno
Copy link
Member

@LuighiV thank you for the PR! I'm looking into it as we speak. Again, thanks.

@all-contributors please add @LuighiV as bug and maintenance

@allcontributors
Copy link
Contributor

@olavoparno

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @LuighiV! 🎉

@olavoparno olavoparno merged commit 4dbe4a2 into the-bugging:main Nov 17, 2022
@olavoparno
Copy link
Member

@LuighiV could you please try again with 1.2.2?

@LuighiV
Copy link
Contributor Author

LuighiV commented Nov 18, 2022

Thank you, @olavoparno, for this update. I've tested and it works now!
Thank you also for adding me to the contributors list 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants