Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
throw
infindOrCreate
API models might have other dependent API models. Ex: An Award needs an Event. The Award's insert method might look like the following -
We do a
findOrCreate
via theEvent.insert
method as opposed to passing theTBAEvent
during theTBAAward.insert
because the context of inserting an Award does not guarantee having an Event object.This insert is problematic though because the insert can throw. Even in a minimal situation where we insert an Event object with just a key, our Core Data fetch (the find half of
findOrCreate
) can fail.Misc
insert
ininsert
methods failing - should be able to fail gracefully (in some situations)TBAEvent
key
unique constraint backasyncMap
to using async collection methods in iOS 16isOrphaned
to useTBAWebcast
implementation