forked from JabRef/jabref
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update code_smells_56773_reviewlog.txt
- Loading branch information
1 parent
c5ec325
commit 0b8d6c6
Showing
1 changed file
with
3 additions
and
1 deletion.
There are no files selected for viewing
4 changes: 3 additions & 1 deletion
4
Project/Phase 1/Sprint 1/team_member_56773/code_smells_56773_reviewlog.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
Delete later. | ||
Team Meber 56971, João Vieira: | ||
Regarding Long Parameter List: | ||
"Yes I agree that parameter lists of these 3 constructors are too long, I also think both your proposed fixes will probably be necesserary in some cases. For example in the GuiPreferences.java constructor, even if we bundle the position and size parameters into its own class, we will still have a paramters list of size 6, which is still too long." |