Matcher cache/series #8045
Merged
Matcher cache/series #8045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
matcher-cache/Series
branch
from
79db03f to
3e2e473
Compare
yeya24
reviewed
Jan 7, 2025
Signed-off-by: alanprot <[email protected]>
|
BTW: I think we should only cache regex matchers, as they are the only ones that can be problematic. WDYT @pedro-stanaka @yeya24 ? |
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
|
First of all, thanks for wrapping up this work.
I agree with this, maybe we can do it in a follow up. The failure on unit test seems legit. |
Signed-off-by: alanprot <[email protected]>
It was a problem in the test. Fixed. |
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
matcher-cache/Series
branch
from
7126b9a to
602eda9
Compare
pedro-stanaka
approved these changes
Jan 7, 2025
Signed-off-by: alanprot <[email protected]>
yeya24
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implementing the same matcher cache from #7353 but for store-gateways.
There also 2 small changes on the cr:
Verification
Unit test was update to use the cache.