Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: Update deprecated linter configurations #7641

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

mjtrangoni
Copy link
Contributor

Hi,

This is a trivial PR, which fixes some configuration deprecation warnings reported by golangci-lint.
See here.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Replace deprecated run.deadline with run.timeout.
  • Replace deprecated run.skip-dirs with issues.exclude-dirs.
  • Fix output format configuration
  • Fix errcheck configuration

Verification

make go-lint

See,
level=warning msg="[config_reader] The configuration option `linters.errcheck.exclude` is deprecated, please use `linters.errcheck.exclude-functions`."

Signed-off-by: Mario Trangoni <[email protected]>
See,
level=warning msg="[config_reader] The configuration option `output.format` is deprecated, please use `output.formats`"

Signed-off-by: Mario Trangoni <[email protected]>
See,
level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`."

Signed-off-by: Mario Trangoni <[email protected]>
Copy link
Contributor

@pedro-stanaka pedro-stanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@fpetkovski fpetkovski merged commit 825b7c6 into thanos-io:main Aug 15, 2024
20 checks passed
@mjtrangoni mjtrangoni deleted the fix-errcheck branch August 15, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants