Sidecar: Fix process external label on promethues v2.28+ use units.Bytes config type #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanjm
force-pushed
the
fix/sidecar-fix-unmarshal-prom-config
branch
from
b04c6d3 to
546bc3c
Compare
yeya24
reviewed
Sep 14, 2021
hanjm
force-pushed
the
fix/sidecar-fix-unmarshal-prom-config
branch
3 times, most recently
from
49217fd to
c631328
Compare
Done. |
…Bytes config type (thanos-io#4656) Signed-off-by: hanjm <[email protected]>
Signed-off-by: hanjm <[email protected]>
hanjm
force-pushed
the
fix/sidecar-fix-unmarshal-prom-config
branch
from
c631328 to
2e021bc
Compare
bwplotka
pushed a commit
that referenced
this pull request
Sep 20, 2021
…tes config type (#4657) * Sidecar: Fix process external label when promethues v2.28+ use units.Bytes config type (#4656) Signed-off-by: hanjm <[email protected]> * E2E: Upgrade prometheus image version Signed-off-by: hanjm <[email protected]>
kakkoyun
pushed a commit
that referenced
this pull request
Sep 20, 2021
* Sidecar: Fix process external label on promethues v2.28+ use units.Bytes config type (#4657) * Sidecar: Fix process external label when promethues v2.28+ use units.Bytes config type (#4656) Signed-off-by: hanjm <[email protected]> * E2E: Upgrade prometheus image version Signed-off-by: hanjm <[email protected]> * upgrade Prometheus dependency version to v2.30.0 (#4669) * upgrade Prometheus dependency version to v2.30.0 Signed-off-by: Ben Ye <[email protected]> * fix unit test Signed-off-by: Ben Ye <[email protected]> # Conflicts: # go.mod # go.sum * Query: Fix (*exemplarsStream).receive/(*metricMetadataStream).receive/(*targetsStreamStream).receive infinite loop when target response Unimplemented error (#4676) (#4681) Signed-off-by: hanjm <[email protected]> * Cut 0.23.0-rc.1 Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Jimmiehan <[email protected]> Co-authored-by: Ben Ye <[email protected]>
bwplotka
added a commit
that referenced
this pull request
Oct 6, 2021
* Cut release 0.23.0-rc.0 (#4625) Signed-off-by: Bartlomiej Plotka <[email protected]> * Updated version. Signed-off-by: Bartlomiej Plotka <[email protected]> * Cut 0.23.0-rc.1 and cherry picked 3 critical commits from main. (#4684) * Sidecar: Fix process external label on promethues v2.28+ use units.Bytes config type (#4657) * Sidecar: Fix process external label when promethues v2.28+ use units.Bytes config type (#4656) Signed-off-by: hanjm <[email protected]> * E2E: Upgrade prometheus image version Signed-off-by: hanjm <[email protected]> * upgrade Prometheus dependency version to v2.30.0 (#4669) * upgrade Prometheus dependency version to v2.30.0 Signed-off-by: Ben Ye <[email protected]> * fix unit test Signed-off-by: Ben Ye <[email protected]> # Conflicts: # go.mod # go.sum * Query: Fix (*exemplarsStream).receive/(*metricMetadataStream).receive/(*targetsStreamStream).receive infinite loop when target response Unimplemented error (#4676) (#4681) Signed-off-by: hanjm <[email protected]> * Cut 0.23.0-rc.1 Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Jimmiehan <[email protected]> Co-authored-by: Ben Ye <[email protected]> * Cut 0.23.0 release. (#4697) * Endpointset: Do not use info client to obtain metadata (for now) (#4714) * Do not use info client to obtain metadata Signed-off-by: Matej Gera <[email protected]> * Update CHANGELOG. Signed-off-by: Matej Gera <[email protected]> * Comment out client.info usage Signed-off-by: Matej Gera <[email protected]> * Fix lint error Signed-off-by: Matej Gera <[email protected]> * Cutting 0.23.1 (#4718) Signed-off-by: Bartlomiej Plotka <[email protected]> * Moved tutorials Thanos versions to 0.23.1 Signed-off-by: Bartlomiej Plotka <[email protected]> * Added volounteer for shepharding, fixed VERSION. Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Jimmiehan <[email protected]> Co-authored-by: Ben Ye <[email protected]> Co-authored-by: Matej Gera <[email protected]>
someshkoli
pushed a commit
to someshkoli/thanos
that referenced
this pull request
Nov 7, 2021
…tes config type (thanos-io#4657) * Sidecar: Fix process external label when promethues v2.28+ use units.Bytes config type (thanos-io#4656) Signed-off-by: hanjm <[email protected]> * E2E: Upgrade prometheus image version Signed-off-by: hanjm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4656
Signed-off-by: hanjm [email protected]
Changes
Verification