Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support max_item_size for query frontend memcached cache #3920

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 12, 2021

Signed-off-by: yeya24 [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #3895

This pr upgrades Cortex and support max_item_size in query frontend Memcached config.

Verification

@yeya24 yeya24 force-pushed the support-memcached-maxitemsize branch from d182a75 to 669b9b5 Compare March 12, 2021 03:44
pracucci
pracucci previously approved these changes Mar 12, 2021
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a nit). Good job! 👏

docs/components/query-frontend.md Outdated Show resolved Hide resolved
@kakkoyun
Copy link
Member

Hey @yeya24. We're going to cut a release candidate soon, is there any chance for you to rebase and push this to the finish line?

@yeya24 yeya24 force-pushed the support-memcached-maxitemsize branch from 669b9b5 to c449cae Compare April 19, 2021 16:02
@yeya24
Copy link
Contributor Author

yeya24 commented Apr 19, 2021

@kakkoyun Thank you. Please take a look.

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kakkoyun kakkoyun merged commit e486beb into thanos-io:main Apr 20, 2021
@yeya24 yeya24 deleted the support-memcached-maxitemsize branch April 20, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting max item size for the memcached client (query-frontend)
3 participants